Skip to content

Call the syncdb management command inside lambda handler#786

Merged
rapidray12 merged 2 commits intodevelopfrom
AL-fix-syncdb-lambda
Feb 20, 2025
Merged

Call the syncdb management command inside lambda handler#786
rapidray12 merged 2 commits intodevelopfrom
AL-fix-syncdb-lambda

Conversation

@aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Feb 4, 2025

🗣 Description

Call the syncdb management command inside lambda handler instead of repeating the same same code.

The management command was only used for local and then there was a mirrored script for the producion lambda. Instead, the production lambda will call the local script.

💭 Motivation and context

Repetitive code can cause a lot of issues. Fro example, someone fixes syncdb on the local version, but then doesn't update the actual lambda call.

🧪 Testing

Passes pre-commit and github checks.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@aloftus23 aloftus23 self-assigned this Feb 4, 2025
@aloftus23 aloftus23 marked this pull request as ready for review February 20, 2025 18:14
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@rapidray12 rapidray12 merged commit ccec7c8 into develop Feb 20, 2025
14 of 15 checks passed
@rapidray12 rapidray12 deleted the AL-fix-syncdb-lambda branch February 20, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants